Skip to content

Fix Windows NTP server concatenation#185

Open
jcmoore3 wants to merge 1 commit intocloudbase:masterfrom
jcmoore3:fix-windows-ntp-server
Open

Fix Windows NTP server concatenation#185
jcmoore3 wants to merge 1 commit intocloudbase:masterfrom
jcmoore3:fix-windows-ntp-server

Conversation

@jcmoore3
Copy link

Ensure the list of NTP servers is space delimited

Ensure the list of NTP servers is space delimited
@ader1990
Copy link
Member

Hello, thank you for the proposed fix.

Adding here the reason for this change - according to the
https://learn.microsoft.com/en-us/windows-server/networking/windows-time-service/windows-time-service-tools-and-settings?tabs=config#command-line-parameters-for-w32time:

/manualpeerlist:<peers>: Sets the manual peer list to <peers>, which is a space-delimited list of Domain Name System (DNS) or IP addresses. When you specify multiple peers, this option must be enclosed in quotation marks.

@ader1990
Copy link
Member

We will be soon switching to Github PRs (currently still using opendev) and one of the requirements will be the DCO with signed commits. Can you please add the link to the documentation in your commit and sign the commit?

Thanks.

@ader1990
Copy link
Member

Also, if you can please rebase the PR so that I can trigger the workflows runs. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants